The purpose of this study was to compare contemporary risk of hip fracture in type 1 and type 2 diabetes with the nondiabetic population. Using a national diabetes database, we identified those with type 1 and type 2 diabetes who were aged 20 to 84 years and alive anytime from January 1, 2005 to December 31, 2007. All hospitalized events for hip fracture in 2005 to 2007 for diabetes patients were linked and compared with general population counts. Age- and calendar-year-adjusted incidence rate ratios were calculated by diabetes type and sex. One hundred five hip fractures occurred in 21,033 people (59,585 person-years) with type 1 diabetes; 1421 in 180,841 people (462,120 person-years) with type 2 diabetes; and 11,733 hip fractures over 10,980,599 person-years in the nondiabetic population (3.66 million people). Those with type 1 diabetes had substantially elevated risks of hip fracture compared with the general population incidence risk ratio (IRR) of 3.28 (95% confidence interval [CI] 2.52-4.26) in men and 3.54 (CI 2.75-4.57) in women. The IRR was greater at younger ages, but absolute risk difference was greatest at older ages. In type 2 diabetes, there was no elevation in risk among men (IRR 0.97 [CI 0.92-1.02]) and the increase in risk in women was small (IRR 1.05 [CI 1.01-1.10]). There remains a substantial elevation relative risk of hip fracture in people with type 1 diabetes, but the relative risk is much lower than in earlier studies. In contrast, there is currently little elevation in overall hip fracture risk with type 2 diabetes, but this may mask elevations in risk in particular subgroups of type 2 diabetes patients with different body mass indexes, diabetes duration, or drug exposure. © 2014 The Authors. Journal of Bone and Mineral Research published by Wiley Periodicals, Inc. on behalf of the American Society for Bone and Mineral Research. This is an open access article under the terms of the Creative Commons Attribution License, which permits use, distribution and reproduction in any medium, provided the original work is properly cited.